Run integration tests in the default CI build#270
Merged
vharseko merged 1 commit intoJul 11, 2026
Conversation
The Build Maven workflow stopped at the package phase, so failsafe integration tests (*IT.java) in jaspi-functional-tests and framework-functional-tests never ran on pull requests — they were only exercised by the deploy workflow on master. Switch the build to mvn verify so the integration-test and verify phases run in CI, which also enables the persistit animal-sniffer API compatibility check.
vharseko
added
ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Build Maven workflow runs
mvn package, which stops before theintegration-testandverifyphases. As a result, the failsafe integration tests (*IT.java) never run on pull requests:commons/auth-filters/authn-filter/jaspi-functional-tests— 7 TestNG IT classes (run in-process, no container)commons/auth-filters/authz-filter/framework-functional-tests— TestNG ITs deployed to Tomcat 10/11 via Cargo (surefire is explicitly excluded there, so nothing runs at all)They were only exercised indirectly by the deploy workflow on
master(mvn deploygoes through the full lifecycle).Change
Switch the build command from
mvn packagetomvn verify, so every CI build runs the integration tests. This also activates theverify-phase checks that were previously skipped: the persistit animal-sniffer Java API compatibility check and source jar attachment.Validation
mvn verifyon both functional-test modules (JDK 26): 48 + 72 tests pass, including Tomcat 11 startup via Cargo.mvn verifyon persistit modules: animal-sniffer check passes.masteralready runs these phases viamvn deploy(JDK 11, ubuntu) and is consistently green.